docs(android): UI Kit ringing pages for v6.2.0 - #607

🤖 Review Buddy (review-docs-pr)

Recommendation: request changes. Automated review; the final decision stays with a maintainer.

TL;DR: The structure is safe: no build breaks, no 404s, no broken links. The class and function names I spot-checked exist at v6.2.0. But the whole PR rests on one false claim: that the UI Kit brings the Calls SDK. It doesn't. In all three UI Kit modules at v6.2.0, calls-sdk-android is compileOnly. The published 6.2.0 POMs on Cloudsmith (chatuikit-kotlin-android, chatuikit-compose-android, chatuikit-core-android) don't list it. Every v6.2.0 sample app (master-app-*, sample-app-*-push) adds implementation(libs.calls.sdk.android) itself. This PR also removes the calls-sdk-android line from every Gradle snippet and deletes the NoClassDefFoundError warning. So someone who follows Calling Integration as written gets setEnableCalling(true) without the Calls SDK, and the app crashes in Application.onCreate.

P0: blocker

1. The pages say the UI Kit includes calls-sdk-android, but it doesn't, and following them crashes the app at launch. At v6.2.0, chatuikit-core/build.gradle.kts:140, chatuikit-kotlin/build.gradle.kts:209 and chatuikit-compose/build.gradle.kts:207 all use compileOnly(libs.calls.sdk.android). The POM is generated from the implementation configuration, so compileOnly deps never make it in. I confirmed this against the published 6.2.0 POMs. With enableCalling on and no Calls SDK, initCometChatCalls() throws NoClassDefFoundError (the warning this PR removes). Affected lines:

   • ui-kit/android/calling-integration.mdx:36: "The UI Kit brings the Calls SDK". Neither Step 1 Gradle snippet has calls-sdk-android. The Note at :67 makes declaring it sound like an optional version pin.
   • ui-kit/android/call-features.mdx:10-11: "(brings calls-sdk-android)".
   • ui-kit/android/call-logs.mdx:37: "The Calls SDK ships with the UI Kit; the NoClassDefFoundError row applies only to builds that exclude it". The real situation is the opposite: every build excludes it unless the app adds it.
   • ui-kit/android/getting-started.mdx:18,44,117,132,141, getting-started-kotlin.mdx:17,51,92,104 and getting-started-jetpack.mdx:17,51,97,109: "ships with / comes with / brings in". The enableCalling crash warning is replaced by a Note that drops the crash.
   • notifications/android-push-notifications.mdx:90,104: the UI Kit Gradle example has no Calls SDK, and the text says "6.2.0 or later, which brings the Calls SDK".
   • ui-kit/android/llms-android-v6.mdx:138: drops the NoClassDefFoundError row, so an agent can't map the crash to its fix.
   • ui-kit/android/troubleshooting.mdx:81: "Call buttons not appearing → enableCalling not set" needs a row for the missing artifact.

   Fix: add implementation("com.cometchat:calls-sdk-android:5.1.0") to every UI Kit calling snippet (Step 1 tabs, getting-started ×3, push page TOML + dependencies). Reword the "brings / ships with" sentences as "add the Calls SDK alongside the UI Kit". Restore the enableCalling ⇒ Calls SDK artifact warning and the llms troubleshooting row. If the UI Kit is meant to bring the Calls SDK, that's a UI Kit change (api/implementation + POM). The docs shouldn't say it until a release ships it.

P1: should fix before merge

2. The SDK-direct Gradle coordinates are gone from the generic Push page. notifications/android-push-notifications.mdx:60-70,90: the TOML drops cometchat-sdk (chat-sdk-android) and cometchat-calls (calls-sdk-android 5.1.0). The UI Kit becomes the only listed path. This page serves SDK-only and calls-only apps too (:106 says "a calls-only app ships without it"), and they no longer get the artifact names. Keep both paths, for example as UI Kit / SDKs tabs. Once #1 is fixed, the UI Kit tab needs calls-sdk-android as well.

P2: nits

3. ui-kit/android/ongoing-call.mdx:149: Prerequisites say "RECORD_AUDIO and CAMERA declared in the manifest". calling-integration.mdx:237 and upgrading-from-v5.mdx:385 say "There is nothing to declare … merge into your manifest". Use the same wording on all three pages.
4. ui-kit/android/getting-started.mdx:45: "Gradle plugin 4.0.1 or later" (unchanged line) now sits next to the Java 17 bump. It contradicts the AGP 8.9.1 / compileSdk 36 requirement that push ringing adds (stated on the Push and migration pages). Update it to 8.9.1.
5. ui-kit/android/methods.mdx:78: setCallSettingsBuilder is listed as taking CometChatCalls.SessionSettingsBuilder. At v6.2.0 the signature is setCallSettingsBuilder(builder: Any) (UIKitSettings.kt:196). Add "(typed Any so the UI Kit compiles without the Calls SDK)" so readers aren't surprised.

What passed

• Build is safe: 0 dangling docs.json nav refs; the new ui-kit/android/ongoing-call entry resolves.
• No 404s: 0 removed/renamed files, so redirects aren't needed (delta +0). No chained redirects.
• Links: 0 broken internal links or anchors across 70 scanned ui-kit/android/ files and 30 calls/android/ files.
• Images: every image ref on the changed pages resolves. No TODO/FIXME/placeholders.
• API accuracy (spot-checked at v6.2.0 / Push release/2.0): launchOngoingCallActivity (both overloads, both toolkits), CallRingingUtils.buildIncomingCall (parameters match), permissionsForCallType (mic, plus camera only for video), CallInitiationUtils.initiateUserCall, CometChatCallActivity.launchOutgoingCallScreen, getIncomingCallTheme / incomingCallTheme / CometChatIncomingCallTheme, CometChatCallEvent.{OutgoingCall,CallAccepted,CallRejected,CallEnded}, setOnCallInitiated / setOnStartDirectCall / setOnCallTypeIconClick / onCallIconClick / onAcceptRequested, DEFAULT_RING_TIMEOUT_MS 45 000 / DEFAULT_CLOSE_GRACE_MS 1 500, ACTIVE_CALL / CALL_IN_PROGRESS. The cometchat_pn_call_* light/dark hex values in color-resources.mdx match chatuikit-core/src/main/res/values{,-night}/cometchat_pn_ring_theme.xml. Push SDK: CallBundles.getCall, IncomingCall fields, CometChatCallNotifications.answer/decline/onIncomingCallScreenOpened/Closed, ensureRingReady, PNCallback.valueOrNull, setIncomingCallTheme.
• Pre-existing, not from this PR: /ui-kit/android/llms-android-v6 isn't in the nav. That looks intentional for an llms index page.
• Skipped: no Mintlify build or preview render was run locally. The Mintlify preview bot reports 🟢 Ready.

🤖 Review Buddy (review-docs-pr)

Recommendation: request changes. Automated review; the final decision stays with a maintainer.

Re-review at b611dd3, following the earlier review of f39c274.

TL;DR: The P0 from the first review is fixed. Every UI Kit calling snippet now adds calls-sdk-android:5.1.0. The "brings / ships with" wording is gone. The enableCalling + artifact pairing is back on Calling Integration, all three Getting Started pages, Troubleshooting and the llms index. The push page keeps both the UI Kit and SDK-direct paths. All three P2 nits are fixed too. One new problem came in with the fix: the new text says that with the artifact missing, "the calling components then crash with NoClassDefFoundError". At v6.2.0 they don't crash. Each one checks CallsUtils.isCallsSDKAvailable() and fails quietly. So the symptom the pages describe isn't what a developer will see. The build is still safe and there are still no 404s or broken links.

P0: blocker

None.

P1: should fix before merge

1. The missing-Calls-SDK symptom is wrong for 6.2.0. The components fail quietly instead of crashing. At v6.2.0:

   • Call Logs: CometChatCallLogsViewModel.kt:127 returns early when the SDK is absent. It logs "Calls SDK is not on the classpath; skipping call-log fetch" and shows the empty state.
   • Call screen: CometChatOngoingCallViewModel.kt:235 (ENG-39311) logs "cannot start the ongoing call" and returns.
   • Call Buttons: CallInitiationUtils.kt:73 returns Result.failure(CometChatException("CALLS_SDK_MISSING", …)). Its listeners are gated too (CometChatCallButtonsViewModel.kt:177,213).

   Where it's stated:

   • ui-kit/android/calling-integration.mdx:69: "the calling components you then show (Call Buttons, Call Logs, the call screens) crash with NoClassDefFoundError"
   • ui-kit/android/getting-started-kotlin.mdx:51 and getting-started-jetpack.mdx:51: "the calling components then crash with NoClassDefFoundError"
   • ui-kit/android/troubleshooting.mdx:82: the symptom column starts with the crash. The init log string is right; keep it.
   • ui-kit/android/call-logs.mdx:41 (touched by this PR) says the NoClassDefFoundError row "applies to every app that does not declare the artifact". The Warning above it (:15-23, unchanged) says CometChatCallLogs has "no availability check" and CRASHES. That was true before ENG-39311 but no longer is at 6.2.0. The absent row should read "empty list + skipping call-log fetch warning in logcat". The present / enableCalling=false row (CometChatCalls.init() RuntimeException) wasn't re-checked here. Verify it on device before keeping it.
   • ui-kit/android/llms-android-v6.mdx:138: same crash framing for agents.

   Fix: describe the 6.2.0 behaviour. Init logs …not on the classpath; skipping Calls init. Call Logs then shows an empty list, the call buttons fail with CALLS_SDK_MISSING, and the call screen doesn't start. Each one logs a "Calls SDK is not on the classpath" warning. Keep the crash for "older UI Kits" only, if that's still worth mentioning.

P2: nits

2. notifications/android-push-notifications.mdx:53: the unchanged intro "Two CometChat artifacts, published in lockstep. The calls one is optional" no longer fits. The snippet below it now lists the UI Kit, the Calls SDK and both push artifacts. Reword it, e.g. "The Push Notifications SDK is two artifacts…".
3. notifications/android-push-notifications.mdx:95: in the UI Kit block, the comment implementation(libs.cometchat.calls) // needed with the calls module suggests a UI Kit app only needs the Calls SDK for ringing. With setEnableCalling(true) it needs it for any calling. Suggest // needed for calling (enableCalling) and for the calls module.

Earlier findings: status at b611dd3

• ✅ P0 (UI Kit "brings" the Calls SDK): fixed. calls-sdk-android:5.1.0 is in Calling Integration step 1 (both tabs), Getting Started ×3 (catalog + Gradle tabs), Call Logs, the push page and Upgrading from v5. The wording was fixed on every page that said it. The pairing Warning is restored at calling-integration.mdx:69, and there's a new Troubleshooting row. Checked against v6.2.0: compileOnly(libs.calls.sdk.android) at chatuikit-core/build.gradle.kts:140, chatuikit-kotlin:209, chatuikit-compose:207. The init log string matches CometChatUIKit.kt:152-153.
• ✅ P1 (SDK-direct coordinates on the push page): fixed. The TOML has cometchat-sdk (chat-sdk-android 5.1.1) and cometchat-calls (5.1.0). The Gradle block shows both the UI Kit path and the SDK-direct path.
• ✅ P2 permissions wording: ongoing-call.mdx:149 now says "nothing to declare", matching Calling Integration and Upgrading from v5.
• ✅ P2 AGP: getting-started.mdx:45 now says AGP 8.9.1 and compileSdk 36. coreKtx = "1.18.0" at v6.2.0.
• ✅ P2 setCallSettingsBuilder: methods.mdx:78 now says it's typed Any.

What passed

• Build is safe: 0 dangling docs.json nav refs. The ui-kit/android/ongoing-call entry resolves.
• No 404s: nothing removed or renamed, redirect delta +0, no chained redirects.
• Links: 0 broken internal links across ui-kit/android/ (70 files), calls/android/ (30) and notifications/ (26).
• Orphans: only /ui-kit/android/llms-android-v6. It was already orphaned before this PR, which looks intentional for an llms index.
• API spot-checks from the first review still hold. Commit 2 only changed dependency and wording text.
• Skipped: no local Mintlify build or render. The Mintlify preview bot reports 🟢 Ready. No on-device check of the missing-artifact behaviour; the finding above comes from reading the v6.2.0 source.

✅ Approved via Review Buddy after an automated review (P0: 0 · P1: 1 · P2: 2).

Findings: #607 (review)

🤖 Review Buddy (review-docs-pr)

Recommendation: approve. Automated review; the final decision stays with a maintainer.

Round 3, reviewing 0234bed. Earlier rounds reviewed f39c274 and b611dd3.

TL;DR: The round-2 P1 and both P2s are fixed. The pages now describe what UI Kit 6.2.0 actually does when the Calls SDK is missing: init logs a warning and skips the Calls SDK, Call Logs shows the empty state, the call buttons fail with CALLS_SDK_MISSING, and the call screen doesn't start. The pre-6.2.0 crash is kept as history. I checked each of those claims against the v6.2.0 source. One small wording nit is left. The build is safe, and there are no 404s or broken links.

P0: blocker

None.

P1: should fix before merge

None.

P2: nits

1. ui-kit/android/calling-integration.mdx:69 has two small problems:
   • "it logs …skipping Calls init, finishes chat init without calling." is a comma splice. Use "…and finishes chat init without calling."
   • "each with its own Calls SDK is not on the classpath warning in logcat" isn't true for the call buttons. CallInitiationUtils.kt:74-77 returns CometChatException("CALLS_SDK_MISSING", "calls-sdk-android is not on the classpath"), and CometChatCallButtonsViewModel.kt:136-148 sends it to the error state/onError without logging it. Only Call Logs (CometChatCallLogsViewModel.kt:130) and the call screen (CometChatOngoingCallViewModel.kt:237) write that warning to logcat. Suggested fix: "Call Logs and the call screen log Calls SDK is not on the classpath; the call buttons report CALLS_SDK_MISSING through onError." The init warning still shows up in logcat in every case, so the Troubleshooting row at troubleshooting.mdx:82 is fine as written.

Earlier findings: status at 0234bed

• ✅ P1 (missing-Calls-SDK symptom was a crash): fixed in calling-integration.mdx:69, getting-started-kotlin.mdx:51, getting-started-jetpack.mdx:51, troubleshooting.mdx:82, llms-android-v6.mdx:138 and call-logs.mdx:15-25. Checked against v6.2.0:
  • The Call Logs absent row matches CometChatCallLogsViewModel.kt:126-134, which logs "skipping call-log fetch" and sets CallLogsUIState.Empty.
  • The present / enableCalling=false row ("Error state") matches the onFailure → CallLogsUIState.Error path at :160-162. The source comment at :125 says the same. I didn't check this on a device.
  • No page still says "crash" for 6.2.0. NoClassDefFoundError now appears only as pre-6.2.0 history.
• ✅ P2 (push page intro): android-push-notifications.mdx:53 now says "The Push Notifications SDK is two artifacts…" and names the UI Kit / Chat / Calls lines in the snippet.
• ✅ P2 (push page Calls comment): :96 now says "needed for calling (enableCalling) and for the calls module".
• ✅ The round-1 P0 (UI Kit "brings" the Calls SDK) is still fixed. A grep for "brings / ships with / bundles the Calls" across ui-kit/android, calls/android and the push page finds nothing.

What passed

• Build is safe: 0 dangling docs.json nav refs. ui-kit/android/ongoing-call resolves.
• No 404s: nothing removed or renamed, redirect delta +0 (927 → 927), and no chained redirects.
• Links: 0 broken internal links across ui-kit/android/ (70 files), calls/android/ (30) and notifications/ (26).
• Orphans: only /ui-kit/android/llms-android-v6. It was already orphaned before this PR, which looks intentional for an llms index.
• Placeholders: no TODO/FIXME/TBD in the new or rewritten pages.
• Skipped: I didn't run a local Mintlify build or render; the Mintlify preview bot reports 🟢 Ready at 0234bed. I didn't test the missing-artifact behaviour on a device; the notes above come from reading the v6.2.0 source.

✅ Approved via Review Buddy after an automated review (P0: 0 · P1: 0 · P2: 1).

Findings: #607 (review)